Make all Meson level options overridable per subproject. #14251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzini
reviewed
Feb 13, 2025
bonzini
reviewed
Feb 13, 2025
jpakkane
force-pushed
the
optionrefactor3
branch
from
518c732 to
eaf1735
Compare
dcbaker
reviewed
Feb 13, 2025
jpakkane
force-pushed
the
optionrefactor3
branch
from
eaf1735 to
aeaf918
Compare
|
Is it possible to modify the meson error message to find which option breaks the rule? |
Can you open a new issue here on GitHub? |
|
I'm wondering if this simple question requires its own dedicated issue. Perhaps the author of the patch could consider addressing it as a minor enhancement? |
|
I'm going to lock this PR now as we're tracking regressions and issues with a milestone. If you have issues related to this PR, please see if there is an opened issue like yours and comment there, or open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is finally it. #13441 rebased and squashed down to a single commit. All known issues have been fixed apart from the performance slowdown already handled elsewhere.
We are very close to the point of no return. If there are any more comments or objections to make, the time is right now. If nothing is raised, I'll merge this later today.